Pull Request PHP Process

Process to review PHP code in GitHub Main (master branch)

  1. On your GUI tools SourceTree or TortoiseGit
    • Create a new Branch > FE-Fixed
      new-branch
    • Name (it can be any name that make sense for you and it will be delete when your work done)
    • Don't forget to checkout new branch
  2. Edit or fix your code
  3. Commit and Push to FE-Fixed (branch that you have created don't touch the Master)
  4. Back to GitHub Main (prontodev/pronto-core)
    • Create a new pull request by comparing changes across two branches
      (base: master) (compare: Choose a head branch)
      pull-new-request
    • Add pull request Title and comment
      comments
    • Then select your Reviewers zkan, sandysaille or parnpresso
  5. On the Trello move card from FE backlog to Platform Development > Code Review lane
  6. Copy your pull URL paste to #pr-review-with-fe Slack channel
  7. GOOD if your request approved reviewers are going to merge it
  8. BAD please follow all comments from reviewer to fix it on your branch and 2nd fixing no need to create a new pull request again

Note

  • Beware of extra spaces and PHP Format
  • Sublime Text uses tabs instead of spaces for indentation (tab width:4)