Pull Request PHP Process

Process to review PHP code in GitHub Main (master branch)

On your GUI tools SourceTree or TortoiseGit

Create a new Branch > FE-Fixed

Name (it can be any name that make sense for you and it will be delete when your work done)
Don't forget to checkout new branch

Edit or fix your code
Commit and Push to FE-Fixed (branch that you have created don't touch the Master)
Back to GitHub Main (prontodev/pronto-core)

Create a new pull request by comparing changes across two branches (base: master) (compare: Choose a head branch)

Add pull request Title and comment

Then select your Reviewers zkan, sandysaille or parnpresso

On the Trello move card from FE backlog to Platform Development > Code Review lane
Copy your pull URL paste to #pr-review-with-fe Slack channel
GOOD if your request approved reviewers are going to merge it
BAD please follow all comments from reviewer to fix it on your branch and 2nd fixing no need to create a new pull request again

Note

Beware of extra spaces and PHP Format
Sublime Text uses tabs instead of spaces for indentation (tab width:4)